[Discuss] Async use cases #1306
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bendk
force-pushed
the
async-use-cases-doc
branch
from
ba95ac5 to
392da0a
Compare
bendk
commented
Aug 4, 2022
|
|
||
| - Rust code making an async call into a CallbackInterface / Foreign code | ||
| making an async into Rust. I think this could be implemented by having | ||
| UniFFI generate something like the hand-written demo from #1252. |
There was a problem hiding this comment.
This seems like a nice feature, but I'm not sure it's necessary. I think we could implement the Nimbus work with hand-written code. Maybe we could just start there and see if there's more demand before generating that code with UniFFI.
There was a problem hiding this comment.
I agree that hand-writing & using it that way seems sensible. That's how UniFFI was born to begin with.
bendk
commented
Aug 4, 2022
| UniFFI generate something like the hand-written demo from #1252. | ||
| - Handling CallbackInterface calls from a Rust-based thread. I'm not exactly sure how this would work, there's at least 2 options here: | ||
| - Handle everything on the foreign side. In the generate code we currently register a callback to invoke a CallbackInterface call. We might be able to update that code so that it schedules the call to run on the correct thread. But this assumes that it's safe to call that callback on the Rust thread. Is that true for all of our current languages? Are we okay with adding this requirement for future languages? | ||
| - Use a queue plus a waker. Push the CallbackInterface call to a queue, signal the foreign side (maybe writing a byte to a pipe or socket), then the foreign side would wake up and try to read from the queue. This seems more complicated than the first system, but might let us support more foreign languages. |
There was a problem hiding this comment.
This feature seems necessary if we ever want to make a call from a Rust controlled (or C++ controlled) thread into JS. Maybe we want that for the Nimubs desktop work, but I'm not sure.
41 tasks
|
I think we have a good plan here, no need to keep this PR open longer. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I don't know if this document should be added to the docs section, the main reason I'm opening the PR is so we can discuss the use cases more.